Thread Safety fixes for TrkEvent (part 3 or so)

• There is a follow up on this !23269 (merged) After a further discussion with @goetz we decided to go with my initial proposal of moving the const_cast from inside the EDM classes to the "problematic" TrackSlimmingTool code that needs them. The actual solution for the TrackSlimmingTool is now to be followed here https://its.cern.ch/jira/browse/ATLASRECTS-4950

• Remove mutable in TrkSegment,TrkPseudoMeasurementOnTrack

• Add override, final in TrkCaloCluster_OnTrack

• TrkCaloClusterROI needed not be virtual.

This merge request affects 2 packages:

• Tracking/TrkEvent/TrkTrack
• Tracking/TrkTools/TrkTrackSlimmingTool

added Tracking master review-pending-level-1 labels

changed title from Move the const_cast from the EDM to the problematic tool to TrackStateonSurface move the const_cast from the EDM to the problematic TrackSlimmingTool

changed the description

added 1 commit

• 491a9842 - ATLAS THREAD SAFETY fixes

Compare with previous version

changed title from TrackStateonSurface move the const_cast from the EDM to the problematic TrackSlimmingTool to Thread Safety fixes for TrkEvent

changed title from Thread Safety fixes for TrkEvent to Thread Safety fixes for TrkEvent (part 3 or so)

changed the description

This merge request affects 8 packages:

• Tracking/TrkEvent/TrkCaloClusterROI
• Tracking/TrkEvent/TrkCaloCluster_OnTrack
• Tracking/TrkEvent/TrkCompetingRIOsOnTrack
• Tracking/TrkEvent/TrkLinks
• Tracking/TrkEvent/TrkPseudoMeasurementOnTrack
• Tracking/TrkEvent/TrkSegment
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkTools/TrkTrackSlimmingTool

This merge request affects 8 packages:

• Tracking/TrkEvent/TrkCaloClusterROI
• Tracking/TrkEvent/TrkCaloCluster_OnTrack
• Tracking/TrkEvent/TrkCompetingRIOsOnTrack
• Tracking/TrkEvent/TrkLinks
• Tracking/TrkEvent/TrkPseudoMeasurementOnTrack
• Tracking/TrkEvent/TrkSegment
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkTools/TrkTrackSlimmingTool

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23329-2019-05-10-22-35
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38293]

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23329-2019-05-11-00-08
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38305]

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23329-2019-05-11-01-13
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38307]

changed the description

Looks fine to me, so approving...

    Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 5fc0e9d6

added sweep:ignore label