Code cleanup of TrkAmbiguitySolver (ATLASRECTS-3038)

Code cleanup of TrkAmbiguitySolver

• Use ATH_MSG macro
• Use default destructor
• Use range based for loop
• Sort includes
• Move initialization to the header file

RunTier0Tests.py was fine. RunTier0Tests.log

This merge request affects 1 package:

• Tracking/TrkAlgorithms/TrkAmbiguitySolver

added Tracking master review-pending-level-1 labels

changed the description

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23364-2019-05-13-06-41
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38348]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d14e5ccb

added sweep:ignore label

changed title from Code cleanup of TrkAmbiguitySolver to Code cleanup of TrkAmbiguitySolver (ATLASRECTS-3038)