Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 193
    • Merge requests 193
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !23373

Merged
Created May 13, 2019 by Frank Winklmeier@fwinklMaintainer

Fix thinning of HLTResult (ATR-18627)

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 2

The thinning was never applied to the old-style HLT::HLTResult as it is stored as const in the event store. Fix this by const-cast. The thinning of the xAOD::TrigNavigation worked as it's already non-const in the store.

Besides fixing the bug, removed one templated method as we need different treatment for the const/non-const case.

For reference, this changes the trigger output in q431:

05-13 14:20 ERROR    Py:diff-root         INFO  [HLT::HLTResult_p1_HLTResult_HLT]: 1622 leaves differ
05-13 14:20 ERROR    Py:diff-root         INFO  [HLT::HLTResult_p1_HLTResult_HLT.m_navigationResult]: 40693 leaves differ

This change was also validated in 21.0. For the moment, we don't want to add it there but the RunTier0Tests.log file is attached.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hltresult_thinning