Fix thinning of HLTResult (ATR-18627)

The thinning was never applied to the old-style HLT::HLTResult as it is stored as const in the event store. Fix this by const-cast. The thinning of the xAOD::TrigNavigation worked as it's already non-const in the store.

Besides fixing the bug, removed one templated method as we need different treatment for the const/non-const case.

For reference, this changes the trigger output in q431:

05-13 14:20 ERROR    Py:diff-root         INFO  [HLT::HLTResult_p1_HLTResult_HLT]: 1622 leaves differ
05-13 14:20 ERROR    Py:diff-root         INFO  [HLT::HLTResult_p1_HLTResult_HLT.m_navigationResult]: 40693 leaves differ

This change was also validated in 21.0. For the moment, we don't want to add it there but the RunTier0Tests.log file is attached.

@tbold can you take a look at this?

This merge request affects 1 package:

• Trigger/TrigEvent/TrigNavTools

added Trigger master review-pending-level-1 labels

Yes. It looks ok to me.

resolved all discussions

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23373-2019-05-13-20-57
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38375]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 7a0e131e

added sweep:ignore label