Re enable precision calo for electrons

This MR is to enable precisionCalo for electrons by default discussed in ATR-19704. This includes

• Uncomment precisionCalo related lines in ElectronDef.py
• A fix in name of output container of topoClusters in TrigT2CaloCommon/python/CaloDef.py
• Fixed precisionCaloRec.py so to use the topoCluster instance in RoI (as in !23321 (merged))

Result of test_trigUpgr_slice_electron_build in afs:

/afs/cern.ch/user/f/fernando/public/ATR-19704/test_trigUpgr_slice_electron_build

added Egamma Trigger TriggerMenu master labels

Oh I see !23484 (merged) got merged while I was preparing this one. I'll merge those changes in and retry this one

Hi @fernando,

I think you only need to un-comment the following lines because I changed to the right address of PrecisionCaloRec while merging,

https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/ElectronDef.py#L15

https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/ElectronDef.py#L29 & L30

https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/ElectronDef.py#L57

https://gitlab.cern.ch/atlas/athena/blob/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Egamma/ElectronDef.py#L78 , 79, 80, 81

Thanks, Debo.

The changes look good to me. Do you understand why there is no rejection after topo clustering? Is this expected.

Hi Fernando, I think you also need to update the runMenu test reference. Cheers, Catrin

added 73 commits

• ca01b183...81b2f5dd - 71 commits from branch atlas:master
• 4cc5a269 - merged with master
• e02b4bd9 - Updated reference and ElectronDef.py to cope with new location of PrecisionCaloSequenceSetup

Compare with previous version

Hi all,

I just merged master and fixed location of PrecionCaloHypo and new reference for electron slice. @bernius : Oh, I see... How can I update that reference? I'll do WIP now so I avoid triggering all the CI untill I update runMenu reference

marked as a Work In Progress

changed the description

You need to run the test test_trigUpgr_runMenuTest_build.sh That should give you an updated reference file but things might have changed, not tried it recently.

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TriggerMenuMT

Adding @hartj ,@damazio ,@rbielski as watchers

added review-pending-level-1 label

Hi @bernius,

even I need to confirm this new method

The new method in the link says, in build directory, ctest -j10 2>&1 | tee run_log.log

and in separate run directory do the following to get all the print outs runTrigART.py -m TrigUpgradeTest

Thanks, Debo.

unmarked as a Work In Progress

Hi @bernius, I ran test_trigUpgr_runMenuTest_build.sh and found difference in all other signatures (i.e. my counts were 0 while references were something). I guess this test should be executed after a full menu (or all signature-enagled) test? I then, didn't change anything else and removed WIP. please let me know otherwise

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23502-2019-05-17-20-33
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 38622]

I see, the test failing is

"ctest -R TriggerMenuMT_generateMenuMT_ctes"

I'll fix it and push again. Fer

added review-user-action-required label and removed review-pending-level-1 label

added 144 commits

• e02b4bd9...6686088e - 138 commits from branch atlas:master
• 8a572f02 - Adding PrecisionCalo to electron Chains
• b8623e1c - Added Electron precisionCalo
• 20e52d66 - added new electron reference
• ca5db34c - Updated reference and ElectronDef.py to cope with new location of PrecisionCaloSequenceSetup
• c4c4665a - Merge branch '22_ReEnablePrecisionCaloFunctions' of...
• 8f08c505 - Rebased to master

Compare with previous version

I rebased to master and removed again Electron precision calo from ElectronDef, but left defined the corresponding functions so we can test them with full_menu.py.