Skip to content
Snippets Groups Projects

SUSYTools: extra protections for compressed EWK searches

Merged Julia Lynne Gonski requested to merge jgonski/athena:dev-compressed-ewk into 21.2
All threads resolved!

Consolidating various hacks and additions that we've made to SUSYTools for the compressed EWK analysis, for ease of eventual analysis preservation and combinations. Two extra protections are added to account for crashes that came up (justifications in line). We also have four updated cross section files that I've been adding by hand into our local SUSYTools, but unsure if these have been added to PMG and/or elsewhere and this is actually redundant.

Tagging @oabouzei, @ykeisuke, @jmiguens, @szambito, as well as @miholzbo and @jshahini who might know more about the cross section situation.

Thanks!

Edited by Keisuke Yoshihara

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • thanks @jgonski !

    We don't want to maintain xsec files anymore, feel free to open CENTRPAGE JIRA for xsecs. For other two lines, can you test them locally? If it works fine for you and no need to update the reference (which we can see in this MR), I would be happy to proceed with this MR.

    Keisuke

  • Hi @ykeisuke, thanks for the feedback! We'll follow the xsecs up elsewhere in the JIRA then. As for the other changes, is there any particular output you're looking for in terms of local tests? We've been running our productions with these changes for several months, and they don't have any effect except to avoid the crashes mentioned. As long as the logic of checking for vertices/caloClusters makes sense to you, I think we can call these safe. I'm removing the xsec files and will resolve the WIP status once you confirm.

    Thanks again! Julia

  • Julia Lynne Gonski changed the description

    changed the description

  • reopened

  • Keisuke Yoshihara unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Keisuke Yoshihara changed title from SUSYTools extra protections and xsec extensions for compressed ewk to SUSYTools: extra protections for compressed EWK searches

    changed title from SUSYTools extra protections and xsec extensions for compressed ewk to SUSYTools: extra protections for compressed EWK searches

  • thanks Julia! I've removed WIP, let's see if CI works!

    Keisuke

  • This merge request affects 1 package:

    • PhysicsAnalysis/SUSYPhys/SUSYTools

    Adding @zmarshal ,@oabouzei ,@szambito ,@ykeisuke ,@cohm as watchers

  • added 60 commits

    • 328549e7...60dc8957 - 58 commits from branch atlas:21.2
    • 45fe2023 - Removing xsec files from MR
    • 9ea15c25 - Merge remote-tracking branch 'upstream/21.2' into dev-compressed-ewk

    Compare with previous version

  • :negative_squared_cross_mark: CI Result FAILURE

    AnalysisBase AnalysisTop AthAnalysis AthDerivation
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-23698-2019-05-28-03-12
    :warning: AnalysisBase: number of compilation errors 0, warnings 1
    :warning: AnalysisTop: number of compilation errors 0, warnings 1
    :warning: AthAnalysis: number of compilation errors 0, warnings 3
    :warning: AthDerivation: number of compilation errors 0, warnings 11
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 39051]

  • It seems like the other MR (!23590 (merged)) has to get going before this MR.

  • Hi,

    While we wait for (!23590 (merged)), please, remember to close the discussions still open so that we can proceed with the merge faster.

    Cheers, Miguel

  • Julia Lynne Gonski resolved all discussions

    resolved all discussions

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • PhysicsAnalysis/SUSYPhys/SUSYTools

    Adding @zmarshal ,@oabouzei ,@szambito ,@ykeisuke ,@cohm as watchers

  • :white_check_mark: CI Result SUCCESS

    AnalysisBase AnalysisTop AthAnalysis AthDerivation
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-23698-2019-05-28-21-01
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisTop: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 39113]

  • mentioned in commit 15ca986d

  • Please register or sign in to reply
    Loading