Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !23717

Merged
Created May 26, 2019 by Pierre Antoine Delsart@delsartDeveloper

Update TrackCaloCluster tools to allow creation of UFO (== TCC created from PFlow objects)

  • Overview 53
  • Commits 9
  • Pipelines 2
  • Changes 47

There are many changes, so I'll cc the main authors of TCC code @ncalace, @rjansky, @sschramm and authors of UFO code @jroloff and @dportill

The goal of this MR is to add code enabling the building of UFO objects in the TCC packages. The changes here brings a lot of code re-organization : this was necessary to factorize common code between TCC and UFO building and also allows to make the future migration to master & athena MT easier (ex: use of private tools, prefer uing algs rather than tools when possible).

The physics algorithms for TCC have not changed, and all my tests so far have shown results 100% identical with the original code. I'll remove the WIP flags if/when we have agreed these changes are ok and final tests also show identical results.

Some details about the changes :

  • a new TrackCaloClusterInfo object is introduced. Its purpose is to hold all the necessary info to build TCC or UFO : maps of weights and original track, cluster and vertex containers. It's transient only (can be put in the evtStore)
  • new AthenaAlgs to build TrackCaloClusterInfo : one for TCC one for UFO. They replaces the previous weight creator tool and they are TrackCaloClusterInfoAlg and TrackCaloClusterInfoUFOAlg
  • new interface for tools building TrackCaloCluster objects : ITrackCaloClusterTool. Tools inheriting it are tasked to build one specific "taste" of TCC or UFO.
  • new AthenaAlg to drive the creation the creation TCC or UFO object by calling a sequence of ITrackCaloClusterTool (TrackCaloClusterAlg) and passing them the TrackCaloClusterInfo created by previous TrackCaloClusterInfoAlg
  • a few Athena AlgTools implementing the ITrackCaloClusterTool interface.
  • The original algs and tools have been removed to avoid confusion with the new ones

As there are a lot of change, I'm very open to discussion. Please do not hesitate to comment or suggest changes !

Edited Jun 09, 2019 by Binish Batool
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ufoRecoDevel