Skip to content

21.9: Temporary fix for ITK pixel cabling to skip validity checks

Nicholas Styles requested to merge nstyles/athena:21.9-PixelCablingSvc into 21.9

Changes to the PixelCablingService configuration to allow step 3.0 layouts to run. This effectively just disables the checking of the mapping validity when reading it in, but since we do not currently use the PixelCablingSvc this should not be a problem. If desired I could add some better handling of this, that will print a WARNING or ERROR if we try to actually retrieve any information via the PixelCablingSvc while DisableChecks is True so that it is clearer that this is not yet reliable.

Longer term we should fix this "properly" in one of two ways:

  • Find a way to avoid having this as part of the configuration altogether while it is not needed
  • Or simply add a map for step 3.0

My preferred solution would be the former, but I see that we have changes to this package in master, so it may be better to wait before making major changes. For the latter we'd need to wait for !23552 (merged) since this will change the Identifiers. Probably this should also be discussed with an ITK pixel offline coordinator once we have one.

FYI @nova @npetters @asalzbur @lmijovic @goblirsc

Edited by Binish Batool

Merge request reports

Loading