Skip to content

GitLab

Modernize IOVSvcTool

Merged Frank Winklmeier requested to merge fwinkl/athena:iovsvctool_modernize into master

Modernize IOVSvcTool:

  • Use MsgStream from base class and macros where relevant
  • 0 -> nullptr
  • add virtual/override
  • move properties to header

In principal these should all be entirely transparent changes, except:

Because of the use of the common messaging, the message source name of messages emitted by IOVSvcTool changes. Previously this was hard-coded to "IOVSvcTool", but now it follows the canonical tool name. Since the name of the tool was set to the store name, this resulted in confusing source names, e.g.

IOVSvc.StoreGate   INFO

To solve this the tool name is now set to "IOVSvcTool" in case the default store ("StoreGateSvc") is used. Otherwise it uses IOVSvcTool_STORENAME. By default this then results in the following message signature:

IOVScv.IOVSvcTool  INFO

Unfortunately, this is still different from what is was before and requires a bunch of updates to test reference files.

Edited by Frank Winklmeier