Prevent CSC strip phi-ordering work-around being used for MC Overlay

The CSC endcaps were modelled with a simple z translation in GeoModel, whereas in data they were built the same i.e. rotated in z. This means that the phi-ordering of the CSC phi strips in A-wheel needs to be flipped to make data and MC strip numbering consistent. This should only happen for data overlay though, so this commit adds a fix to prevent the flip being applied for MC+MC overlay.

added Overlay Run2-MCOverlay-output-changed alsoTargeting:21.0 bugfix labels

After !24169 (merged) is merged will update overlay reference file and drop WIP status.

added 41 commits

• fcc99973...05105afc - 39 commits from branch atlas:master
• d7d08d4f - CscOverlay logging fixes
• 62a902fd - Prevent CSC strip phi-ordering work-around being used for MC Overlay.

Compare with previous version

added 1 commit

• fa043df3 - Update the overlay reference file after CscOverlay MC+MC bugfix.

Compare with previous version

unmarked as a Work In Progress

This merge request affects 2 packages:

• MuonSpectrometer/MuonOverlay/CscOverlay
• Tools/PROCTools

Adding @jchapman ,@rosati ,@amete ,@wleight ,@tkharlam ,@tadej ,@ahaas as watchers

added MuonSpectrometer Tools master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24198-2019-06-14-20-03
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 360]

This should fix ATLASSIM-4079.

Approved by L1 shifter.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit ff528c39

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• 21.0

mentioned in commit jchapman/athena@680c5e84

mentioned in merge request !24370 (merged)

removed sweep:failed label