Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !24317

EventInfo: const fixes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Scott Snyder requested to merge ssnyder/athena:const.EventInfo-20190619 into master Jun 19, 2019
  • Overview 5
  • Commits 2
  • Pipelines 2
  • Changes 6

EventInfo had some const methods that were returning non-const pointers to member data. This violates the spirit of const-correctness (and the thread-safety checker warns about it). Clean up by splitting the affected methods into const and non-const versions, returning const and non-const pointers, respectively.

This could in principle break some existing code. Known issues have been fixed/worked around, but it's possible something got missed.

Edited Jun 19, 2019 by Scott Snyder
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: const.EventInfo-20190619