Skip to content

MdtCalibrationDbSvc MT migration v5

Chikuma Kato requested to merge ckato/athena:master-MdtCalibrationDbSvcMT-v5 into master

Small updates are done following comments in the big MR (!22643 (closed)). AtRndmGenSvc was replaced by AthRNGSvc in prevois MR (!24067 (merged)). This time is

  • using public extends<AthAlgTool, IInterface>
  • using m_regionIdThreshold(2500) in MdtCalibDbAlg
  • checking what exception is expected
  • using detStore directly in MdtCalibrationTool.cxx
  • using unique_ptr in MdtCalibrationTool
  • using ATH_MSG macro in MdtCalibrationTool

The tier0 test was ok (RunTier0Tests.log). The rest are

  • smart pointer migration changing Data
  • avoid dynamic char array in the Alg
  • check temporary things and magic number in the Alg (1.87652e-2)
  • add setter method to the container to check if existing pointers are not overwritten
  • remove DbTool writing ReadCondHandle in clients and passing it to parent Tool
  • run new config in local and remove old Svc

Thank you for comments in the previous request @tadej @wleight

Edited by Chikuma Kato

Merge request reports