Skip to content

Update hit residual and hit efficiency plots in InDetPhysValMonitoring to new ITk identifier scheme

This MR addresses a crash within InDetPhysValMonitoring when running with the updated identifier scheme required for the 'Step 3.0' ITk layouts. The hit residual and hit efficiency plot tools feature a hardcoded number of detector layers. This number has been updated in this MR to match the new identifier scheme, fixing crashes resulting from out-of-bounds array access. To avoid having to hardcode 33 identical histograms in the corresponding XML, a bookProfileForLayer method was added to the hit residual plots, allowing to recycle one generic template histogram definiton in the XML.

For this MR, the aim is to make the code run without crashing with the new identifier scheme - future MR should probably update the tools to generally remove this dependence on hardcoded geometry details, and the reliance on C-style histogram arrays without bounds checking.

Merge request reports