Skip to content

Fix bug in Quick Close Component merger

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:GSFQuickCloseBughfix into master

After [!24778 (merged)]

we see more fit failures i.e SPOT ttbar 12/07/2019

11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO -----------------------------------------------
11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Fit PrepRawData Calls:          0
11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Fit MeasurementBase Calls:      4024
11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Forward Fit Failures:           200
11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Smoother Failures:              462
11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of MakePerigee Failures:           0
11:55:06 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Trks that fail fitquality test: 0

vs SPOT ttbar 11/07/2019

11:23:50 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Fit PrepRawData Calls:          0
11:23:50 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Fit MeasurementBase Calls:      4024
11:23:50 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Forward Fit Failures:           36
11:23:50 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Smoother Failures:              43
11:23:50 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of MakePerigee Failures:           0
11:23:50 EMBremCollectionBuilder.GSFRefitterTool.GSFTrac...   INFO Number of Trks that fail fitquality test: 0

This is a fix, bringing in a "dropped" weights addition. Locally it seems to reduce them back to the previous situation

Mentioning @amorley (which should confirm it makes sense) and @jmitrevs

Edited by Christos Anastopoulos

Merge request reports