Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 173
    • Merge requests 173
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !24885

Pause for 5 seconds before dumping PerfMon results in postFinalize

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Alaettin Serhan Mete requested to merge amete/athena:master-perfmoncomps-update into master Jul 15, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

This is a practical workaround to an issue that is observed in threads>0 jobs. In these jobs, if both ChronoStatSvc and PerfMonSvc are configured, ChronoStatSvc keeps dumping the results table after its finalize, even after issuing an SvcPostFinalize incident which causes PerfMonSvc's output to be garbled in the log file. With this MR we delay dumping PerfMonSvc results for 5 seconds to avoid this until the root cause of the problem is fixed properly.

Please note that I'm well aware that PerfMonSvc is not MT-safe and this is only for some trigger related tests w/ a single-thread job.

cc : @rbielski @ssnyder

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-perfmoncomps-update