Skip to content

21.9: Fix for spurious orientation warnings

Nicholas Styles requested to merge nstyles/athena:21.9-isInclinedFix into 21.9

This MR moves some WARNING messages to DEBUG, since for ITK these get spuriously triggered many times in every job. Unfortunately, it is not easily possible to catch the cases responsible (inclined barrel pixel modules) specifically, since this is in a method that initializes many members in a specific order, and so the IsInclined() method that would be useful here does not work due to the normal not being initialized, which cannot be moved earlier as it relies on transforms that are not yet initialized, etc...

Added also some checking in IsInclined() which will notify users who try to call it too early, which caused confusion in ATLITKSW-70.

FYI @lmijovic @goblirsc @npetters @nreadiof @asalzbur

Merge request reports