AthViews and ViewAlgs: Get scheduler on the fly, not in initialize
Online the scheduler cannot be initialised before forking. Since the View creators need a handle to the scheduler, they have to retrieve it on the fly in execute
because during their initialize
the scheduler is not allowed to exist. This fixes ATR-20012.
I'm sure this is slower (although didn't test how much), but I don't see a better solution right now.
Merge request reports
Activity
- Resolved by Rafal Bielski
Looks good on the C++ side, but aren't you going to need to change a whole lot of python config to make it work?
Looking through LXR now: https://acode-browser.usatlas.bnl.gov/lxr/search?%21v=head&_filestring=&_string=Scheduler+%3D
I see some tests where python config may be affected by these changes. I'll try to update these.
I found also two other uses of direct scheduler handle in AthViews/src_flow:
And one in ViewAlgsTest:
Should I worry about these as well? They are calling ViewHelper::ScheduleViews with a raw pointer to IScheduler, but this still works just calling standard constructor of SmartIF(TYPE*).
added review-pending-level-1 label
CI Result SUCCESS Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-24965-2019-07-19-01-18
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1261] added review-approved label and removed review-pending-level-1 label
mentioned in commit e79e86d9
added sweep:ignore label