Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 118
    • Merge requests 118
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !25023

[ATR-20039] Remove un-used parameter ViewPerRoI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tim Martin requested to merge tamartin/athena:removeViewPerROI into master Jul 22, 2019
  • Overview 6
  • Commits 2
  • Pipelines 2
  • Changes 2

The m_viewPerRoI property is never used. Removing it to avoid it causing confusion.

Think this logic is handled instead by the EventViewCreatorAlgorithmWithJets.cxx or EventViewCreatorAlgorithmWithMuons.cxx variants.

Ping @bwynne @fpastore @tbold

Ping @cvarni due to minor change to bjet

Edited Jul 24, 2019 by Tadej Novak
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: removeViewPerROI