Skip to content
Snippets Groups Projects

Add new tool developed by Jason Saunders (ANL SULI) to change compression settings.

Merged Peter Van Gemmeren requested to merge gemmeren/athena:RootFileTools_Reformat into master

This also reverts latest changes to POOLmerge, which didn't really change compression (because fast cloning was used).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak
  • Tadej Novak
  • Hi @gemmeren,

    It would be nice if you can avoid C-style casts. Otherwise the MR is fine.

    Tadej (L2)

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Database/AthenaPOOL/RootFileTools

    Adding @ssnyder ,@mnowak as watchers

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-25099-2019-07-26-02-42
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1478]

  • Hi @gemmeren, can you please comment on the last remaining discussion? Then this one can be approved.

    Tadej (L2)

  • Peter Van Gemmeren resolved all discussions

    resolved all discussions

  • Hi Tadej, I resolved the discussion and removed the review-user-action-required label. Cheers, Peter

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading