Skip to content

21.9: Remove old db access

Nicholas Styles requested to merge nstyles/athena:21.9-removeOldDBAccess into 21.9

During the effort to clean up ITK logfiles, it was noticed that empty tables were still being accessed from the "old" DDDB geometry structures, which for ITK pixel are now supplanted by Xml files, uploaded to a CLOB.

The old table structures were apparently just being used to pass around names of service types to be built. This is replaced by a string for the name in the first commit of this Merge Request. This is not super-elegant, and can probably be improved further in future, but it was a solution that required minimal knock-on changes to interfaces. Further clean up can probably improve this further, but these changes at least allow a lot of no-longer-needed code to be cleaned out.

The second commit (kept separate for ease of review) is just the removal of the PixelSCTDBHelper package, and removal of any lingering places where this was included (mostly for no good reason that I can see).

I don't see any reason why we would need this old DB access in future, but would ask ITK pixel SW experts like @nreadiof, @nova, @fcostanz, to comment if there are any reasons to keep it.

FYI @asalzbur @npetters @lmijovic @goblirsc

Merge request reports