Improvements to OutputStreamConfig
Updated OutputStreamConfig
module to enable writing EventStreamInfo
and IOVMetaDataContainer
objects to the output file. Some IOVMetaDataContainer objects are still not copied from input to
output file, so there is still work to be done. This change at least allows the outputs of jobs
configured with ComponentAccumulator
to be read by diff-root and therefore allow the outputs
to be compared with jobs configured with the old configuration code.
Merge request reports
Activity
added NewConfig label
I don't claim this to be perfect, but the output files produced look more similar to the standard outputs than previously. :-) There are definitely differences in compression still and some IOVMetaDataContainer objects are not copied from the HITS file to the RDO file in my local tests, so there are still missing pieces.
added Database master review-pending-level-1 labels
CI Result FAILURE Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-25266-2019-07-31-19-19
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1645] OK,
TriggerConfig.py
did not like me renamingOuputStreamXXX
toStreamXXX
:Traceback (most recent call last): File "newJOtest.py", line 54, in <module> acc.merge( triggerRunCfg( flags, generateMenu ) ) File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/python/TriggerJobOpts/TriggerConfig.py", line 389, in triggerRunCfg acc.merge( triggerOutputStreamCfg( flags, decObj, "ESD" ) ) File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/python/TriggerJobOpts/TriggerConfig.py", line 211, in triggerOutputStreamCfg streamAlg = acc.getEventAlgo("OutputStream"+outputType) File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 277, in getEventAlgo raise ConfigurationError("Can not find an algorithm of name %s "% name) AthenaConfiguration.ComponentAccumulator.ConfigurationError: Can not find an algorithm of name OutputStreamESD
It made comparing log file between old and new configurations easier, but will leave it out for now.
CI Result SUCCESS Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-25266-2019-08-01-00-59
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1672] added review-approved label and removed review-pending-level-1 label
mentioned in commit 8245dd1e
added sweep:ignore label