Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 165
    • Merge requests 165
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !25273

Closed
Created Jul 31, 2019 by Miha Muskinja@mmuskinjDeveloper
  • Report abuse
Report abuse

fix to make VKalVrtCvtTool work with size 6 and 21 input error matrices

  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 1

A covariance matrix is symmetric, so there would be 21 distinct elements. However, there's an option in the code to not compute the full covariance, but only the diagonal elements. In that case, we'd have 6 elements.

Currently, VKalVrtCvtTool would try to access all 21 elements of the covariance matrix and start accessing random memory. In my opinion, this is likely a bug as the code seems to be setup in a way to write only diagonal elements of the covariance matrix.

This MR covers both cases; input covariance matrix size 6 and 21 and gives SC FAILURE for all other cases.

Tagging @ssnyder .

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.2-fix-VKalVrtCvtTool