Skip to content

Remove unused methods to fix const correctness issues of TrackSelectionTool

Susumu Oda requested to merge oda/athena:master-TrackSelectionTool into master

Remove unused methods to fix const correctness issues of TrackSelectionTool

http://goetz.web.cern.ch/goetz/mutable_2019-07-13.html#Monitoring,Mon,DQ_Align

 nightly/master/2019-07-13T2149:InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/TrackSelectionTool.cxx +162


   160	      if(msgLvl(MSG::VERBOSE)) msg(MSG::VERBOSE) << "Track automatically passes TrackSelectionTool since passAllTracks=True" << endmsg;
   161	      //selected_tracks->push_back(track);//allow all tracks into new collection, regardless of decision 
   162	      return_tracks->push_back(const_cast<xAOD::TrackParticle*> (track) );
   163	    }
   164	    else {

nightly/master/2019-07-13T2149:InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/TrackSelectionTool.cxx +220


   218	      if(trackPassed) {
   219		//selected_tracks->push_back(track);//allow only tracks that pass decision into the new collection
   220		return_tracks->push_back(const_cast<xAOD::TrackParticle*> (track));
   221		if(msgLvl(MSG::VERBOSE)) msg(MSG::VERBOSE) << "Track passed trackSelectorTool" << endmsg;
   222	      }

nightly/master/2019-07-13T2149:InnerDetector/InDetMonitoring/InDetAlignmentMonitoring/src/TrackSelectionTool.cxx +425


   423	
   424	    //Convert the const Trk::Track to Trk::Track. ATTENTION: writing to the casted object will create undefined behaviour. 
   425	    Trk::Track* trk_p = const_cast<Trk::Track*>(track->track());
   426	   
   427	    if (!trk_p)

RunTier0Tests.py was fine. RunTier0Tests.log

Edited by Susumu Oda

Merge request reports