Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 184
    • Merge requests 184
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !25994

Merged
Created Aug 19, 2019 by Pascal Boeschoten@pboeschoContributor

MuonLayerHoughTool memory leak fixes & improvements

  • Overview 3
  • Commits 5
  • Pipelines 1
  • Changes 7

ATLASRECTS-4869

  • Clean up pointers in HoughDataPerSec destructor to prevent possible memory leak
  • Clean up tgcClusteringObjs in MuonLayerHoughTool::State destructor
  • Avoid inheriting from std::vector
  • Some style changes and documentation that make variable usage and memory management more obvious to the reader

@wleight Unfortunately, I still haven't managed to run Valgrind locally to confirm the fixes due to insufficient resources, and running on lxplus is slow and unreliable (getting kicked off halfway the run). I am proposing to merge the changes (if they pass CI) and then see if the leaks still pop up in the regular Valgrind tests done by the SPOT group. I know this isn't ideal, but it's a way forward at least. The fixes are also just general improvements, and I don't expect they'll make things worse, in any case.

Cheers, Pascal

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: muonlayerhoughtool-memory-leak-fix/master