Skip to content

Remove thread-unsafe static variables in MuonIdHelper base class

John Derek Chapman requested to merge jchapman/athena:MuonIdHelperThreadSafety_master into master

MuonIdHelper::stationNameString and MuonIdHelper::technologyString were returning references to non-const static strings.
This was leading to data races when running Overlay and Digitization (w/o pile-up) in AthenaMT (and presumably reco as well).
The changes in this merge request change the methods to return references to const strings, avoiding the data races.
It may possibly be worth considering returning the strings by value also.

Merge request reports