Skip to content

Fix WriteDecorHandleKey auto-declaring Property constructor

William Keaton Balunas requested to merge wbalunas/athena:wdhk-constructor-2 into master

This fixes an issue with !26025 (merged), which introduced a 4-argument auto-declaring Property constructor for WriteDecorHandleKey. The problem was that the implementation was done inline in WriteDecorHandleKey.h but tried to initialize a member variable which isn't defined until later. The compiler didn't care about this because it wasn't actually used in the previous MR.

Tagging @ssnyder, @leggett (yep, this is exactly what your proposed tests are for, this time I was more careful and actually used the new constructor first).

Merge request reports