Skip to content

[ATR-20332] [ATR-20333] Suppress multiple-link warnings for View fetching in HypoAlgs. Remove "is this expected?" warning

Tim Martin requested to merge tamartin/athena:suppressMostRecentViewWarning_suppressEmptyIMInputWarning into master

Info to egamma, tau, bphys slices. (cc @dbakshig, @fernando, @thrynova, @carquin, @guindon, @malconad, @hrussell, @jakoubek, @abarton )

This MR makes a small change to your HypoAlgs.

Requesting findLink< ViewContainer >( previousDecision, "view") in Step2 and beyond generates a WARNING as the code cannot be sure if you wanted to get a link to the View from Step2, or the View from Step1. The default behaviour was OK in this case (return the most recent). But to avoid these WARNINGs I have updated the HypoAlgs to fetch the View link directly from the Hypo's input rather than doing this search for it. Faster too.

Code now reads const auto viewEL = previousDecision->objectLink<ViewContainer>( viewString() );

I also updated to always use viewString() instead of "view", featureString() instead of "feature" etc.

In addition remove "is this expected?" for empty collections in to InputMakers, it is.

Merge request reports