Fixing mem leak in MuonRdoToMuonDigitTool + cleanup

I fix leaking containers in MuonRdoToMuonDigitTool, restructuring it to make it more reentrant.

I also have a few other cleanups and const-correctness fixes.

Related to ATR-20355