MuonIdHelpers: Add methods to test for the existence of subdetector helpers.
Add MuonIdHelperTool::has*IdHelper(), to provide a correct way of testing for the presence of the subdetector helpers.
Merge request reports
Activity
added MuonSpectrometer master review-pending-level-1 labels
Hi @ssnyder,
thanks for adding these methods. I think if you move to them, you can get rid of the
hasCSC
,hasMM
andhasSTgc
methods and propagate this to all clients. However, keep in mind that also a number of clients could have to be changed. Pinging also @pboescho who will migrate clients step by step to use the ServiceHandle and might be interested in those new methods.For the shifters: Please consider waiting to merge this MR after !27110 (merged) since otherwise !27110 (merged) may have conflicts and !27110 (merged) is much more urgent than this one.
Best, Nico
Edited by Nicolas KoehlerCI Result SUCCESS (hash b6269d55) Athena AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 4450] Hi @jhaley. Can you ping me when you've approved !27110 (merged), so I can proceed with this MR (waiting until !27110 (merged) is merged of course). Cheers, Clara (L1)
Hi @cnellist, !27110 (merged) has been marked as approved. Cheers. ~Joe
mentioned in commit b98c642e
added review-approved label and removed review-pending-level-1 label
added review-pending-level-1 label and removed review-approved label
Hi @nkoehler
Note that this only got merged 3h ago so it's not in any nightlies yet.
Yes, it just breaks the currently running CI jobs, but @fwinkl will revert the merge
Hi @nkoehler
Ah yes, I follow - !27359 (merged)
But how on earth then did this MR manage to pass CI in the first place... investigating...
After !27110 (merged) has been merged this no longer compiles. Reverting this now...
mentioned in commit a719dfe2