Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 165
    • Merge requests 165
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !27434

Fix most MT warnings in MdtSegmentT0Fitter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pascal Boeschoten requested to merge pboescho/athena:master-muonidhelpers-mt-warnings-mdtsgmentt0fitter into master Oct 23, 2019
  • Overview 2
  • Commits 3
  • Pipelines 1
  • Changes 2

This MR fixes many MT warnings in MdtSegmentT0Fitter.

The most significant ones are related to TMinuit. After discussing with @nkoehler and @rosati, it was decided to serialize the TMinuit fitter because it uses global variables to pass data to/from the fit function and there doesn't seem to be an alternative to that. The class will need to be reworked for unrelated reasons anyway.

The only remaining warnings are related to the initializer/finalizer use of the global extern gMinuit variable in the TMinuit header: https://github.com/root-project/root/blob/master/math/minuit/inc/TMinuit.h#L271

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-muonidhelpers-mt-warnings-mdtsgmentt0fitter