Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 135
    • Merge requests 135
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !27468

Implement Run-3 HLT result per-module truncation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rafal Bielski requested to merge rbielski/athena:hlt-truncation into master Oct 24, 2019
  • Overview 29
  • Commits 12
  • Pipelines 3
  • Changes 10

Implemented most of the functionality needed for HLT result truncation handling in Run 3, as discussed in ATR-19852. The largest changes are in the TriggerEDMSerialiserTool, so tagging the author @tbold.

The following changes are done in this MR:

  • Add PSC error code for result truncation (TrigKernel)
  • Add new field with getter/setter functions in HLTResultMT for storing IDs of truncated results (TrigSteeringEvent)
  • Detect and handle the truncation in HltEventLoopMgr, sending the event to a dedicated debug stream (TrigServices)
  • Define truncation thresholds map in TriggerEDMRun3 (TrigEDMConfig)
  • Truncation checks and handling in TriggerEDMSerialiserTool (TrigOutputHandling)
    • Factor out seralisation list parsing and serialisation calls into separate functions
    • Use new tryAddData method to either add serialised data to result or flag it as truncated if threshold is exceeded
    • Keep track of recorded and dropped collections in a new structure TruncationInfo during the fill method
    • In case of truncation:
      • Fill monitoring histograms with moduleID, result size, largest collection name and size
      • Print a useful error message with the same information and the threshold value
      • Create, serialise and record a xAOD::TrigComposite object HLTNav_TruncationDebugInfo with information about type, name, size of all collections - both recorded and dropped. This will be used in offline debugging script for the debug shifter (still to be implemented) for easy diagnostics without rerunning HLT.

Tagging also @okuprash, @dzanzi, @morgens, @ballbroo, @mamuzic

Edited Oct 24, 2019 by Rafal Bielski
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hlt-truncation