Control: Enable flake8 build check

Enable the flake8 build-time check for most packages under Control/. Make the code compliant and if applicable remove the now redundant flake8 unit test.

This merge request affects 20 packages:

• Control/AthenaCommon
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExHelloWorld
• Control/AthenaExamples/AthExJobOptions
• Control/AthenaExamples/AthExThinning
• Control/AthenaKernel
• Control/AthenaMonitoring
• Control/AthenaMonitoringKernel
• Control/AthenaServices
• Control/CLIDComps
• Control/DataModelAthenaPool
• Control/GaudiSequencer
• Control/Hephaestus
• Control/RngComps
• Control/RootUtils
• Control/SGComps
• Control/StoreGateBindings
• Control/StoreGateTests
• Control/Valkyrie
• Control/xAODRootAccess

Adding @ssnyder ,@rbianchi as watchers

added Core DQ master review-pending-level-1 labels

CI Result FAILURE (hash 16ce1786)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 4881]

@fwinkl, I guess no need to restart the pipeline as failures are unrelated. Should we open a ticket for the failing test?

Yes, the failures are unrelated. I think Charles is already looking at those.

OK, approving!

added review-approved label and removed review-pending-level-1 label

mentioned in commit 2c9de94a

merged

added sweep:ignore label