Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 172
    • Merge requests 172
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !27736

Closed
Created Nov 05, 2019 by Chris Malena Delitzsch@cdelitzsDeveloper
  • Report abuse
Report abuse

Avoiding == 0. or != 0. comparison for pFlow charge

  • Overview 26
  • Commits 5
  • Pipelines 5
  • Changes 16

@mhodgkin reported in ATLJETMET-796 that the charge of the pFlow object is compared to != 0.0 instead of using FLT_MIN. This has been hopefully changed now in all instances and also the comparisons to 1e-9 where changed to FLT_MIN

A similar MR will be created for release 21.2. I chose a separate MR given that some files differed between 21.0 and 21.2.

Also tagging @wbalunas, @williams and @khoo for their information.

Edited Nov 05, 2019 by Chris Malena Delitzsch
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.0_pFlow_charge_FLT_MIN