Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
athena
athena
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Jira
    • Jira
  • Labels
  • Merge Requests 214
    • Merge Requests 214
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Commits
  • atlas
  • athenaathena
  • Merge Requests
  • !27737

Merged
Opened Nov 05, 2019 by Chris Malena Delitzsch@cdelitzsDeveloper

Avoiding pFlow charge comparisons to zero and using isCharged() instead

  • Overview 15
  • Commits 2
  • Pipelines 4
  • Changes 17

@mhodgkin reported in ATLJETMET-796 that the charge of the pFlow object is compared to != 0.0 instead of using FLT_MIN. This has been hopefully changed now in all instances and also the comparisons to 1e-9 where changed to FLT_MIN

A similar MR was created for release 21.0, see 27736. A separate MR was used instead of picking targeting also 21.2 due to some file differences between 21.0 and 21.2

Also tagging @wbalunas, @williams and @khoo for their information.

Edited Nov 25, 2019 by Nils Erik Krumnack
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: atlas/athena!27737
Source branch: 21.2_pFlow_charge_FLT_MIN

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.