Use MuonIdHelperTool instead of single sub-helpers
Hi,
by moving to using the MuonIdHelperTool
in AmdcDumpGeoModel
and MuonGMCheck
, the failing ART tests
test_amdc_mgm-test_layout.sh
test_muon_gm_check.sh
test_muon_gm_check_reference.sh
should be fixed.
Best, Nico
Merge request reports
Activity
added sweep:ignore label
added 21.3 MuonSpectrometer review-pending-level-1 labels
Adding sweep:ignore since in
master
it is already migrated and nowhere else these ART tests runCI Result SUCCESS (hash df7bac73) Athena externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 162
For experts only: Jenkins output [CI-MERGE-REQUEST 41373] CI Result SUCCESS (hash df7bac73) Athena externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 162
For experts only: Jenkins output [CI-MERGE-REQUEST 41394] added review-user-action-required label and removed review-pending-level-1 label
Hi @maslawin, can you specify which warning you mean? I can only see a warning in
AtlantisJava
which is for sure not touched by this MR.added review-pending-expert label and removed review-user-action-required label
added review-pending-level-1 label and removed review-pending-expert label
mentioned in merge request !27924 (merged)
I see a list of 162 warnings, including MuonDQAMonitoring, MuonErrorScalingTools, MuonCSC_CnvTools, etc:
for example:
var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/MuonSpectrometer/MuonCnv/MuonCSC_CnvTools/src/CSC_RawDataProviderTool.cxx: In member function 'virtual StatusCode Muon::CSC_RawDataProviderTool::initialize()': /var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/MuonSpectrometer/MuonCnv/MuonCSC_CnvTools/src/CSC_RawDataProviderTool.cxx:58:18: warning: 'MSG::Level CommonMessagingBase::outputLevel() const' is deprecated [-Wdeprecated-declarations]
added review-user-action-required label and removed review-pending-level-1 label
Hi all,
These warnings are (unfortunately) in the nightly: https://bigpanda.cern.ch/nview/?nightly=21.3_Athena_x86_64-slc6-gcc62-opt
For master we should be strict about warnings. For the 21.X releases, we can't ... but in any case, this MR didn't provoke them.
Cheers,
Ed (RC)
added review-pending-level-1 label and removed review-user-action-required label