Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
athena
athena
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Jira
    • Jira
  • Labels
  • Merge Requests 214
    • Merge Requests 214
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Commits
  • atlas
  • athenaathena
  • Merge Requests
  • !28056

Merged
Opened Nov 18, 2019 by Adam Edward Barton@abartonDeveloper

VKalVrt, optimizations

  • Overview 35
  • Commits 1
  • Changes 5

Replace dynamic_cast with virtual call in a hotspot, remove trivial destructors.

Callgrind analysis locates hotspots in this dyanamic_cast code, where 500 events called 100 Million of these dynamic casts. A virtual call is faster than a dynamic_cast.

Combined with the changes in !27919 (merged) this improves VKalVrt performance ~13% without changing output (checked BPHY5 BPHY8).

cc @wwalko

Edited Nov 18, 2019 by Adam Edward Barton
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: atlas/athena!28056
Source branch: devopti2

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.