Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 135
    • Merge requests 135
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !28059

Merged
Created Nov 18, 2019 by Rafal Bielski@rbielski🏖Developer

Avoid using ConcurrencyFlags in Trigger

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 6

AthenaCommon.ConcurrencyFlags are not valid at python-configuration time in online HLT and should be avoided anywhere in Trigger. The Trigger configuration cannot depend on them, since the number of threads/slots is configured from OKS in C++. It can also differ between nodes in the farm and between runs, so changing job configuration based on these numbers should be forbidden in Trigger.

This MR is removing trivial cases where the use was not actually needed (discovered thanks to ATR-20524), and fixing TriggerFlags.doMT stored value.

Also fixing the stored value of OnlineFlags.partitionName even though I couldn't use it here, as explained in the comment in TriggerFlags.

FYI @tbold, @bwynne, @tamartin

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hlt-concurrency-flags