Skip to content

Remove MdtCalibrationDbSvc and MdtCalibrationSvc

Nicolas Koehler requested to merge nkoehler/athena:mdtCalibAlg into master

Hi @emoyse, @rosati, @ckato,

with this MR, I try to help @ckato with his original MR !28040 (closed) for which the Trigger_MT_required-test and Digitization_NewConfig_required-test tests are failing since the MuonConfig package needs to be correctly updated as well when removing MdtCalibrationDbSvc and MdtCalibrationSvc.

I still encounter the issue that in the MuonDataDecodeTest_ctest and MuonDataDecodeTest_Cache_ctest unit tests, I get the error

RuntimeError: merge called with a ComponentAccumulator a dangling private tool MdtCalibrationTool/MdtCalibrationTool

since in line https://gitlab.cern.ch/nkoehler/athena/blob/master/MuonSpectrometer/MuonConfig/python/MuonCalibConfig.py#L406, the MdtCalibrationTool is declared private. When I remove this, those unit tests succeed, but the MuonReconstructionConfig.py and MuonSegmentFindingConfig.py tests fail, since this call https://gitlab.cern.ch/nkoehler/athena/blob/master/MuonSpectrometer/MuonConfig/python/MuonRIO_OnTrackCreatorConfig.py#L63 fails.

Maybe @emoyse knows how to resolve this remaining issue?

Many thanks for your advice, Nico

Edited by Nicolas Koehler

Merge request reports