Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
athena
athena
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Jira
    • Jira
  • Labels
  • Merge Requests 214
    • Merge Requests 214
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Commits
  • atlas
  • athenaathena
  • Merge Requests
  • !28386

Merged
Opened Nov 29, 2019 by Zach Marshall@zmarshalMaintainer

Catching case where first truth vertex is nullptr

  • Overview 9
  • Commits 1
  • Pipelines 2
  • Changes 1

There are cases where the first truth vertex in a record is a nullptr, but subsequent truth vertices are fine. This protects the code against such situations.

This is a weird one. Some generators don't assign signal process vertices, which is what we're really looking for here, so in newer releases they are set like this: https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Generators/EvgenProdTools/src/FixHepMC.cxx#0038

which I believe is equivalent to this code. It seems that the 0th vertex is being dropped during reconstruction, which is also weird, but it is there during evgen. I just opened AGENE-1803 for this, so that it can be tracked there.

Thanks to @jonesel for the report.

Edited Dec 02, 2019 by Nils Erik Krumnack
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: atlas/athena!28386
Source branch: 21.2_VertexPatch

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.