Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !28592

Seeding of random number streams used in TRTDigitizationTool::lateInitialize should not depend on the event number

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:TRT_DigiRandomStream_master into master Dec 06, 2019
  • Overview 6
  • Commits 4
  • Pipelines 1
  • Changes 5

Prior to the changes in this merge request, the random number streams used in the TRTDigitizationTool::lateInitialize method would be seeded based on the event number of the first event number in the job. The results of these calls are effectively cached for the whole job though, this meant that output was not reproducible if events in a file were skipped. The random number streams involved are now seeded based on a configurable property of TRTDigitizationTool, so the results of TRTDigitizationTool::lateInitialize should be independent of which event is run first in the job.

Should be merged after !28583 (merged).

Edited Dec 10, 2019 by John Derek Chapman
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: TRT_DigiRandomStream_master