Skip to content
Snippets Groups Projects

Migrate Monitoring Inclusions

All threads resolved!

I've made the following changes across the entire repository.

  1. #include "AthenaMonitoring/GenericMonitoringTool.h" --> #include "AthenaMonitoringKernel/GenericMonitoringTool.h"
  2. #include "AthenaMonitoring/Monitored.h" --> #include "AthenaMonitoringKernel/Monitored.h"
  3. from AthenaMonitoring.GenericMonitoringTool --> from AthenaMonitoringKernel.GenericMonitoringTool

Watcher: @fwinkl

Here are the packages which I think only rely on AthenaMonitoringKernel, and could have updated CMake files. But I'll let Frank handle that in a separate MR if he thinks it's worth changing.

Package
Calorimeter/CaloRec/
Control/AthenaExamples/AthExMonitored/
HLT/Event/TrigByteStreamCnvSvc/
HLT/Trigger/TrigControl/TrigServices/
InnerDetector/InDetRecAlgs/InDetPriVxFinder/
InnerDetector/InDetRecAlgs/SiSpacePointFormation/
MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerAlgs/MuonSegmentTrackMaker/
Reconstruction/MuonIdentification/MuonCombinedAlgs/
Trigger/TrigAlgorithms/TrigCaloRec/
Trigger/TrigAlgorithms/TrigEFMissingET/
Trigger/TrigAlgorithms/TrigL2MuonSA/
Trigger/TrigAlgorithms/TrigMinBias/
Trigger/TrigAlgorithms/TrigmuComb/
Trigger/TrigAlgorithms/TrigmuIso/
Trigger/TrigAlgorithms/TrigMuonEF/
Trigger/TrigAlgorithms/TrigmuRoI/
Trigger/TrigAlgorithms/TrigT2BeamSpot/
Trigger/TrigAlgorithms/TrigT2CaloCommon/
Trigger/TrigAlgorithms/TrigT2CaloEgamma/
Trigger/TrigAlgorithms/TrigT2MinBias/
Trigger/TrigAlgorithms/TrigTauRec/
Trigger/TrigHypothesis/TrigBjetHypo/
Trigger/TrigHypothesis/TrigBphysHypo/
Trigger/TrigHypothesis/TrigEgammaHypo/
Trigger/TrigHypothesis/TrigHLTJetHypo/
Trigger/TrigHypothesis/TrigMissingETHypo/
Trigger/TrigHypothesis/TrigMultiVarHypo/
Trigger/TrigHypothesis/TrigMuonHypoMT/
Trigger/TrigHypothesis/TrigTauHypo/
Trigger/TrigMonitoring/TrigBjetMonitoring/
Trigger/TrigMonitoring/TrigBphysMonitoring/
Trigger/TrigMonitoring/TrigCaloMonitoring/
Trigger/TrigMonitoring/TrigEgammaMonitoring/
Trigger/TrigMonitoring/TrigHLTMonitoring/
Trigger/TrigMonitoring/TrigMETMonitoring/
Trigger/TrigSteer/DecisionHandling/
Trigger/TrigSteer/L1Decoder/
Trigger/TrigSteer/TrigOutputHandling/

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Please resolve remaining discussion and relabel. Magdalena (L1)

  • Charles Burton added 1 commit

    added 1 commit

    • 951a7c3d - update atlas_include_dir lines

    Compare with previous version

  • CI Result FAILURE (hash 951a7c3d)

    Athena AthSimulation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7891]

  • Jenkins please retry a build

  • CI Result FAILURE (hash 951a7c3d)

    Athena AthSimulation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 7905]

  • There is a crash in the trigger test (ATR-20743) but that is unrelated to the changes here.

    Edited by Frank Winklmeier
  • Frank Winklmeier resolved all threads

    resolved all threads

  • The changes look ok. Adding review-approved label.

    L1 shifter

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Walter Lampl mentioned in commit 800158de

    mentioned in commit 800158de

  • Please register or sign in to reply
    Loading