Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 149
    • Merge requests 149
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !29347

CMake 3.15+ Updates, master branch (2020.01.09.)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Attila Krasznahorkay requested to merge akraszna/athena:CMakeUpdates-master-20200108 into master Jan 09, 2020
  • Overview 24
  • Commits 13
  • Pipelines 1
  • Changes 40

This is a sibling of atlasexternals!595 (merged). It only works with the code proposed in that MR. (Hence it's a WIP, as it wouldn't work as-is. I have additional changes locally, which make sure that my test build uses https://gitlab.cern.ch/akraszna/atlasexternals/tree/CMakeUpdates-master-20200106.

As described in atlasexternals!595 (merged) and in ATLINFR-3157, we need to make some changes to be compatible with CMake 3.15+. These are the proposed changes. 😉

The most important change is that atlas_project(...) no longer receives the name and version of a project. Those now have to be specified in a call to project(...) at the top of the project CMakeLists.txt files. However the version numbers, in practice, are still read in from the same version.txt files as before. So for people not regularly editing the project CMakeLists.txt files, this should not cause any difference.

Most of the documentation / discussion about these updates is in atlasexternals!595 (merged).

Tagging @fwinkl, @tsulaia, @ssnyder and @wlampl.

Edited Jan 31, 2020 by Attila Krasznahorkay
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: CMakeUpdates-master-20200108