Skip to content

Fixed a segfault in FileMetaDataCreatorTool::update() in an ESDtoDPD reco test

Vakhtang Tsulaia requested to merge tsulaia/athena:master-FileMetaDataCreatorTool-segfault into master

The sgfault started to show up after merging !28081 (merged). As a result of this MR, FileMetaDataCreatorTool::beginInputFile() was no longer called, and this lead to a segfault later on inside FileMetaDataCreatorTool::update().

The segfault was fixed by forwarding FileMetaDataCreatorTool::beginInputFile(SG::SourceID&) (which is called by MetaDataSvc) to FileMetaDataCreatorTool::beginInputFile(). A similar trick had already been implemented for FileMetaDataTool.

Fixes the crash reported in ATLASRECTS-5257

CC @gemmeren

CC @krumnack (just a reminder that we need to do some cleanup for AsgMetadataTools, as discussed in December)

Edited by Vakhtang Tsulaia

Merge request reports