AthenaMonitoringKernel: Change 2D histogram names to y_vs_x

Change the 2D histogram names from x_vs_y to the usual naming convention y_vs_x. The change is a trivial one line change in GenericMonitoringTool.py. The other changes in this MR are just to adapt the unit tests.

This change will impact any client that retrieves the histograms by names (e.g. monitoring displays, etc.). Therefore I would like to have explicit approval by DQ (@ponyisi). While I agree this change is potentially disruptive, now is still a good time to fix this before we have too many clients to adapt.

Thanks to @rbielski for pointing out this inconsistency.

This merge request affects 1 package:

• Control/AthenaMonitoringKernel

Adding @ssnyder as watcher

added Core DQ master review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash 436dc894)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 8472]

code changes are clear, CI tests passed, so o.k. to go from L1 perspective. However, since expert is required to approve, I'm just changing the labels.

Roman (L1)

added review-pending-expert label and removed review-pending-level-1 label

approved this merge request

Hi Frank - thanks for making this change. As you say, best to do it now.

added review-approved label and removed review-pending-expert label

merged

mentioned in commit e400a3ff

added sweep:ignore label