Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 158
    • Merge requests 158
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !29902

fix bugs which have been fixed in 21.3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hao Xu requested to merge xuh/athena:master-fix-angle into master Jan 29, 2020
  • Overview 9
  • Commits 2
  • Pipelines 0
  • Changes 5

fix some bugs which have been fixed in 21.3, including a manual sweep of !29722 (merged), upgrade some parameter settings.

MM_DigitizationTool.cxx: update Electronics Threshold from 6000e to 15000e; fixed wrong path angle when calculating particle ionization in gas MM_Electron.cxx: fix the wrong drift length used to calculate drift time for drift electrons MM_ElectronicsResponseSimulation.cxx: remove code that repeatedly defines threshold to directly apply the threshold defined in MM_DigitizationTool.cxx MM_IonizationCluster.cxx: correct the exact position of drift electrons that produced the ionization MM_StripsResponseSimulation.cxx: update avalanche gain from 1.16e4 to 8.0e3; expand range of longitudinal Diffusion from 0-5 to (-5)-5

Edited Jan 30, 2020 by Hao Xu
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-fix-angle