Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 161
    • Merge requests 161
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !29917

BoundarySurfaces pass by const ref

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:tidy_extrapolator into master Jan 29, 2020
  • Overview 3
  • Commits 3
  • Pipelines 1
  • Changes 10

Following !29873 (merged)

class BoundaryCheck
0051 {
     ..............
0063 
0064   bool checkLoc1; //!< check local 1 coordinate
0065   bool checkLoc2; //!< check local 2 coordinate
0066 
0067   double toleranceLoc1; //!< absolute tolerance in local 1 coordinate
0068   double toleranceLoc2; //!< absolute tolerance in local 2 coordinate
0069 
0070   int nSigmas;                 //!< allowed sigmas for chi2 boundary check
0071   AmgSymMatrix(2) lCovariance; //!< local covariance matrix
0072 
0073   BoundaryCheckType bcType;
...........

It seems to carry a bit of non trivial payload. Pass it around by reference rather than copy.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tidy_extrapolator