Skip to content

Fix thread-safety issues in MuonCreatorTool

William Axel Leight requested to merge wleight/athena:MuonCombinedBaseTools_ThreadSafety into master

Remove const_casts by:

  1. Making MuGirlLowBetaTag::getStauExtras() const
  2. Running ambiguity resolution on copies of tracks, since the final goal is to have a set of candidates anyway. Additionally, checks for duplicates are now done using pointer hashes.

Remove the mutable member variable that indicated whether or not ELoss information had been added to the muon, the code can look at the muon to determine if it has ELoss information or not.

Make the ambiguity processor not mutable, there doesn't seem to be any reason for it to be mutable.

(Also, I did a bit of cleanup of commented code.)

Additionally, the MuonCombinedTool will now only use the (very non-thread-safe) MuonCombinedDebuggerTool in serial mode.

Merge request reports