Porting SCT spacepoint formation code to master (ATLIDTRKCP-174)

Hello,

accordingly to what discussed this morning at the ID SW group meeting, I'm preparing a MR for discussing the changes to the SCT space point formation provided by @gavrilen. I would invite people to have a look at the changes: @sroe, @oda, @npetters, @goblirsc, @nstyles, @wlampl, @emoyse.

I have tested that these changes are not changing the output for both q431 and q221.

Cheers, Noemi

added InnerDetector Tracking master labels

changed the description

changed title from WIP: IPorting SCT spacepoint formation code to master (ATLIDTRKCP-174) to WIP: Porting SCT spacepoint formation code to master (ATLIDTRKCP-174)

Codes look fine. But more comments and more meaningful names are welcomed for easier understanding of the calculations.

As the code looks fine, and appears to be ~15% faster, I propose we remove the WIP. The question of variable naming (and clarification) still needs to be addressed, though.

unmarked as a Work In Progress

This merge request affects 2 packages:

• InnerDetector/InDetRecAlgs/SiSpacePointFormation
• InnerDetector/InDetRecTools/SiSpacePointTool

Adding @goetz ,@amorley ,@gavrilen ,@sroe as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 723793b3)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9567]

Hi @ncalace, do you have answers for the the above open questions? If nothing to be done, please return back the review label. Mazuza (L1)

added review-user-action-required label and removed review-pending-level-1 label

I'm going through the code trying to document it. I guess I need @gavrilen helping me for that.

Cheers, Noemi

added 1 commit

• 74ea3e81 - documenting the code, some cleaning

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetRecAlgs/SiSpacePointFormation
• InnerDetector/InDetRecTools/SiSpacePointTool

Adding @goetz ,@amorley ,@gavrilen ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label