Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 140
    • Merge requests 140
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !30216

Implement new Region Selector conditions algorithm and flesh out the new RegSelTool class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Sutton requested to merge sutt/athena:master-rstool into master Feb 08, 2020
  • Overview 19
  • Commits 3
  • Pipelines 3
  • Changes 14

The new approach to provide an individual RegSelTool for each subdetector makes use of the detector cabling information becoming conditions data.

The new RegSelCondAlg is a conditions algorithm that depends - in the first instance - on the pixel cabling conditions data, as a proof of concept, and adds the RS lookup table as conditions data.

The new RegSelTool that has a dependence on the RS lookup table conditions data. This is all to effectively replicate the Run 2 begin run functionality but with the new conditions handling in MT.

A subsequent request consisting of the configuration code needed to use these classes is currently being developed.

This is a first proof of principle implementation - once it is all working correctly any remaining issues will be fixed - remove redundant comments, add tables for other detector subcomponents etc, rather than allow these issues to act as a distraction at this point.

Edited Feb 08, 2020 by Mark Sutton
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-rstool