Skip to content

GitLab

Merged
Created by Susumu Oda@odaContributor

Specify hierarchy of SCT_SIDE or SCT_MODULE for isGood method using IdentifierHash.

DEFAULT hierarchy is used in the isGood method with IdentifierHash. In the isGood method of some SCT conditions tools, true is always returned for the DEFAULT hierarchy. This MR fixes the issue by specifying/checking SCT_SIDE or SCT_MODULE hierarchy.

  • Check SCT_MODULE hierarchy in SCT_ConditionsSummaryTool::isGood(const IdentifierHash&). No changes are expected.
  • Specify SCT_SIDE hierarchy in SCT_ConfigurationConditionsTool::isGood(const IdentifierHash&). No changes are expected.
  • Specify SCT_SIDE hierarchy in SCT_LinkMaskingTool::isGood(const IdentifierHash&). No changes are expected.
  • Specify SCT_SIDE hierarchy in SCT_ModuleVetoTool::isGood(const IdentifierHash& hashId&). No changes are expected.
  • Specify SCT_SIDE hierarchy in SCT_MonitorConditionsTool::isGood(const IdentifierHash&). Changes are expected. Some wafers will be bad.
  • Specify SCT_MODULE hierarchy in SCT_RODVetoTool::isGood(const IdentifierHash&). No changes are expected.

RunTier0Tests.py was run with and without the SCT_MonitorConditionsTool::isGood change. The above expectations were confirmed.

Edited by Susumu Oda