Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 136
    • Merge requests 136
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !30429

Merged
Created Feb 17, 2020 by Stewart Martin-Haugh@smhMaintainer

Remove NaN check from MagFieldService: this should be/is done centrally

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

getField() needs to run very fast - adding a hand-rolled NaN check is a bad idea, especially since we have FPE auditor.

I actually already did this for https://gitlab.cern.ch/atlas/athenaprivate1/merge_requests/3869 but it didn't get swept to master.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: magfield_nan